feat: adds otel-android click instrumentation #200
Closed
+240
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…strumentation-take2
tanderson-ld
commented
Aug 27, 2025
Contributor
Author
There was a problem hiding this comment.
Unmodified vendored file
tanderson-ld
commented
Aug 27, 2025
Contributor
Author
There was a problem hiding this comment.
Unmodified vendored file
tanderson-ld
commented
Aug 27, 2025
Contributor
Author
There was a problem hiding this comment.
Still investigating compilation issue related to bytebuddy and exclusion of okhttp-jvm dependency.
agrognetti
reviewed
Aug 27, 2025
| private var timeoutStartNanos: Long = 0 | ||
|
|
||
| @Volatile | ||
| private var state = State.FOREGROUND |
Contributor
There was a problem hiding this comment.
Since line 69 performs a non atomic operation (check and set), I think @Volatile here is not enough and we should replace it by wrapping the state in an AtomicReference to ensure another thread cannot change the state between the check and the update.
agrognetti
added
android
Contributor
|
@tanderson-ld is this PR no longer needed? |
Contributor
Author
|
I can close it for now, but the branch is useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
O11Y-417
How did you test this change?
Bench testing at the moment. There is a story in the epic to add e2e tests.